Changeset 437 for trunk/kernel/syscalls/sys_thread_create.c

Timestamp:

Mar 28, 2018, 2:40:29 PM (5 years ago)

Author:

alain

Message:

Fix various bugs

File:

• trunk/kernel/syscalls/sys_thread_create.c (modified) (9 diffs)

trunk/kernel/syscalls/sys_thread_create.c

@@ -2 +2 @@
  * sys_thread_create.c - creates a new user thread
  *
- * Author     Alain Greiner (2016,2017)
+ * Author     Alain Greiner (2016,2017,2018)
  *
  * Copyright (c) UPMC Sorbonne Universites
@@ -57 +57 @@
         error_t          error;
 
-        uint32_t         tm_start;
-        uint32_t         tm_end;
-
-        tm_start = hal_get_cycles();
-
         // get parent thead pointer, extended pointer, and process 
         parent     = CURRENT_THREAD;
@@ -67 +62 @@
         process    = parent->process;
 
+#if CONFIG_DEBUG_SYS_THREAD_CREATE
+uint64_t tm_start;
+uint64_t tm_end;
+tm_start = hal_get_cycles();
+if( CONFIG_DEBUG_SYS_THREAD_CREATE < tm_start )
+printk("\n[DBG] %s : thread %x enter / process %x / cycle %d\n"
+__FUNCTION__ , parent , process->pid, (uint32_t)tm_start );
+#endif
+
         // check user_attr in user space & copy to kernel space
     if( user_attr != NULL )
@@ -74 +78 @@
             if( error )
             {
-                    printk("\n[ERROR] in %s : user_attr unmapped\n", __FUNCTION__ );
+
+#if CONFIG_DEBUG_SYSCALLS_ERROR
+printk("\n[ERROR] in %s : user_attr unmapped\n", __FUNCTION__ );
+#endif
                     parent->errno = EINVAL;
                     return -1;
@@ -87 +94 @@
         if( error )
         {
-                printk("\n[ERROR] in %s : start_func unmapped\n", __FUNCTION__ );
+
+#if CONFIG_DEBUG_SYSCALLS_ERROR
+printk("\n[ERROR] in %s : start_func unmapped\n", __FUNCTION__ );
+#endif
                 parent->errno = EINVAL;
                 return -1;
@@ -97 +107 @@
         if( error )
         {
-                printk("\n[ERROR] in %s : start_arg unmapped\n", __FUNCTION__ );
+
+#if CONFIG_DEBUG_SYSCALLS_ERROR
+printk("\n[ERROR] in %s : start_arg unmapped\n", __FUNCTION__ );
+#endif
                 parent->errno = EINVAL;
                 return -1;
@@ -110 +123 @@
                     if( cluster_is_undefined( kern_attr.cxy ) )
                     {
-                            printk("\n[ERROR] in %s : illegal target cluster = %x\n",
-                            __FUNCTION__ , kern_attr.cxy );
+
+#if CONFIG_DEBUG_SYSCALLS_ERROR
+printk("\n[ERROR] in %s : illegal target cluster = %x\n", __FUNCTION__ , kern_attr.cxy );
+#endif
                             parent->errno = EINVAL;
                             return -1;
@@ -158 +173 @@
         if( error )
         {
-                printk("\n[ERROR] in %s : cannot create thread\n", __FUNCTION__ );
+
+#if CONFIG_DEBUG_SYSCALLS_ERROR
+printk("\n[ERROR] in %s : cannot create thread\n", __FUNCTION__ );
+#endif
                 return ENOMEM;
         }
@@ -178 +196 @@
     hal_fence();
 
-        tm_end = hal_get_cycles();
-
-syscall_dmsg("\n[DBG] %s : core[%x,%d] created thread %x for process %x / cycle %d\n"
-"      cluster %x / cost = %d cycles\n",
-__FUNCTION__ , local_cxy , parent->core->lid , trdid , process->pid , tm_end ,
-target_cxy , tm_end - tm_start );
+#if CONFIG_DEBUG_SYS_THREAD_CREATE
+tm_end = hal_get_cycles();
+if( CONFIG_DEBUG_SYS_THREAD_CREATE < tm_end )
+printk("\n[DBG] %s : thread %x created thread %x for process %x in cluster %x / cycle %d\n"
+__FUNCTION__, parent, child_ptr, process->pid, target_cxy, (uint32_t)tm_end );
+#endif
 
         return 0;