Changeset 440 for trunk/kernel/syscalls/sys_kill.c

Timestamp:

May 3, 2018, 5:51:22 PM (6 years ago)

Author:

alain

Message:

1/ Fix a bug in the Multithreaded "sort" applicationr:
The pthread_create() arguments must be declared as global variables.
2/ The exit syscall can be called by any thread of a process..

File:

• trunk/kernel/syscalls/sys_kill.c (modified) (4 diffs)

trunk/kernel/syscalls/sys_kill.c

@@ -2 +2 @@
  * sys_kill.c - Kernel function implementing the "kill" system call.
  * 
- * Author    Alain Greiner (2016,2017)
+ * Author    Alain Greiner (2016,2017,2018)
  *
  * Copyright (c)  UPMC Sorbonne Universites
@@ -38 +38 @@
 {
     xptr_t      owner_xp;      // extended pointer on target process in owner cluster
-    cxy_t       owner_cxy;     // target process owner cluster
+    cxy_t       owner_cxy;     // target process in owner cluster
     process_t * owner_ptr;     // local pointer on target process in owner cluster
-    xptr_t      parent_xp;     // extended pointer on parent process
-    cxy_t       parent_cxy;    // parent process cluster
-    process_t * parent_ptr;    // local pointer on parent process
-    pid_t       ppid;          // parent process PID
     uint32_t    retval;        // return value for the switch
 
     thread_t  * this    = CURRENT_THREAD;
     process_t * process = this->process;
-    trdid_t     trdid   = this->trdid;
 
 #if DEBUG_SYS_KILL
@@ -75 +70 @@
     }
 
-    // process can kill itself only when calling thread is the main thread
-    if( (pid == process->pid) && ((owner_cxy != local_cxy) || (LTID_FROM_TRDID( trdid ))) ) 
+    // process cannot kill itself
+    if( (pid == process->pid) ) 
     {
 
 #if DEBUG_SYSCALLS_ERROR
-printk("\n[ERROR] in %s : only main thread can kill itself\n", __FUNCTION__ );
+printk("\n[ERROR] in %s : process %x cannot kill itself\n", __FUNCTION__, pid );
 #endif
         this->errno = EINVAL;
@@ -86 +81 @@
     }
 
-    // get parent process PID
-    parent_xp  = hal_remote_lwd( XPTR( owner_cxy , &owner_ptr->parent_xp ) );
-    parent_cxy = GET_CXY( parent_xp );
-    parent_ptr = GET_PTR( parent_xp );
-    ppid       = hal_remote_lw( XPTR( parent_cxy , &parent_ptr->pid ) );
-
-    // check processe INIT 
+    // processe INIT cannot be killed
     if( pid == 1 )
     {