Changeset 441 for trunk/kernel/syscalls/sys_exec.c

Timestamp:

May 9, 2018, 3:13:56 PM (6 years ago)

Author:

alain

Message:

Fix a bug in rpc_vmm_get_pte_client() function (bad RPC index).

File:

• trunk/kernel/syscalls/sys_exec.c (modified) (6 diffs)

trunk/kernel/syscalls/sys_exec.c

@@ -150 +150 @@
 // Implementation note:
 // This function must be called by the main thread (thread 0 in owner cluster).
-// IT build an exec_info_t structure containing all informations
+// It build an exec_info_t structure containing all informations
 // required to initialize the new process descriptor and the associated thread.
 // It includes the process main() arguments, the environment variables, 
@@ -208 +208 @@
 tm_start = hal_get_cycles();
 if( DEBUG_SYS_EXEC < tm_start )
-printk("\n[DBG] %s : thread %x enter / process %x / path %s / cycle = %d\n",
+printk("\n[DBG] %s : thread %x in process %x enter for path <%s> / cycle = %d\n",
 __FUNCTION__, this, pid, exec_info.path, (uint32_t)tm_start );
 #endif
@@ -219 +219 @@
 
 #if DEBUG_SYSCALLS_ERROR
-printk("\n[ERROR] in %s : cannot access args\n", __FUNCTION__ );
+printk("\n[ERROR] in %s : thread %x in process %x cannot access args\n",
+__FUNCTION__ , this, pid );
 #endif
             this->errno = EINVAL;
@@ -233 +234 @@
 
 #if DEBUG_SYCALLS_ERROR
-printk("\n[ERROR] in %s : cannot access envs\n", __FUNCTION__ );
+printk("\n[ERROR] in %s : thread %x in process %x cannot access envs\n",
+__FUNCTION__ , this, pid );
 #endif
             this->errno = EINVAL;
@@ -247 +249 @@
 
 #if DEBUG_SYSCALLS_ERROR
-printk("\n[ERROR] in %s : cannot create process %x in cluster %x\n",
-__FUNCTION__, pid, CXY_FROM_PID(pid) );
+printk("\n[ERROR] in %s : thread %x in process %x cannot create process for <%s>\n",
+__FUNCTION__, this, pid, exec_info.path );
 #endif
         this->errno = error;
@@ -257 +259 @@
 tm_end = hal_get_cycles();
 if( DEBUG_SYS_EXEC < tm_end )
-printk("\n[DBG] %s : thread %x exit / process %x / cost = %d / cycle %d\n",
+printk("\n[DBG] %s : thread %x in process %x exit / cost = %d / cycle %d\n",
 __FUNCTION__, this, pid, (uint32_t)(tm_end - tm_start), (uint32_t)tm_end );
 #endif
 
-    // deschedule <=> old thread suicide because the BLOCKED_GLOBAL
-    // and the FLAG_REQ_DELETE have been set by process_make_exec()
+    // In case of success, this calling thread deschedules, causing suicide,
+    // because a new process descriptor and its associated main thread 
+    // have been created by the process_make_exec() function, and the
+    // BLOCKED_GLOBAL & FLAG_REQ_DELETE bits have been set for the calling thread. 
     sched_yield( "old process suicide in sys_exec()" );
 
-    assert( false , __FUNCTION__ , "This code should not be executed\n" );
-
     return 0;