Changeset 457 for trunk/kernel/syscalls/sys_exec.c

Timestamp:

Aug 2, 2018, 11:47:13 AM (6 years ago)

Author:

alain

Message:

This version modifies the exec syscall and fixes a large number of small bugs.
The version number has been updated (0.1)

File:

• trunk/kernel/syscalls/sys_exec.c (modified) (8 diffs)

trunk/kernel/syscalls/sys_exec.c

@@ -23 +23 @@
 
 #include <kernel_config.h>
-#include <hal_types.h>
+#include <hal_kernel_types.h>
 #include <hal_uspace.h>
 #include <errno.h>
@@ -152 +152 @@
 // It build an exec_info_t structure containing all informations
 // required to initialize the new process descriptor and the associated thread.
-// It includes the process main() arguments, the environment variables, 
+// It includes the new process main() arguments, the environment variables, 
 // and the pathname to the new process .elf file. 
 // It calls the process_exec_get_strings() functions to copy the main() arguments and 
 // the environment variables from user buffers to the exec_info_t structure, allocate
 // and call the process_make_exec() function.
-// As it must destroy all parent process copies, and all parent threads in all clusters,
-// the process_make_exec() function must be executed in the parent owner cluster, 
-// and this sys_exec() function uses a RPC to access the owner cluster if required. 
+// As it must destroy all process copies, and all othert threads in all clusters,
+// the process_make_exec() function must be executed in the owner cluster. 
 // 
 // TODO : the args & envs arguments are not supported yet : both must be NULL  [AG]
@@ -187 +186 @@
     "args not supported yet\n" );
 
-    // get owner cluster
-
     // check pathname length
     if( hal_strlen_from_uspace( pathname ) >= CONFIG_VFS_MAX_PATH_LENGTH )
@@ -205 +202 @@
 #if DEBUG_SYS_EXEC
 uint64_t      tm_start;
-uint64_t      tm_end;
 tm_start = hal_get_cycles();
 if( DEBUG_SYS_EXEC < tm_start )
 printk("\n[DBG] %s : thread %x in process %x enter for path <%s> / cycle = %d\n",
-__FUNCTION__, this, pid, exec_info.path, (uint32_t)tm_start );
+__FUNCTION__, this->trdid, pid, exec_info.path, (uint32_t)tm_start );
 #endif
 
@@ -220 +216 @@
 #if DEBUG_SYSCALLS_ERROR
 printk("\n[ERROR] in %s : thread %x in process %x cannot access args\n",
-__FUNCTION__ , this, pid );
+__FUNCTION__ , this->trdid, pid );
 #endif
             this->errno = EINVAL;
@@ -235 +231 @@
 #if DEBUG_SYCALLS_ERROR
 printk("\n[ERROR] in %s : thread %x in process %x cannot access envs\n",
-__FUNCTION__ , this, pid );
+__FUNCTION__ , this->trdid, pid );
 #endif
             this->errno = EINVAL;
@@ -250 +246 @@
 #if DEBUG_SYSCALLS_ERROR
 printk("\n[ERROR] in %s : thread %x in process %x cannot create process for <%s>\n",
-__FUNCTION__, this, pid, exec_info.path );
+__FUNCTION__, this->trdid, pid, exec_info.path );
 #endif
         this->errno = error;
@@ -256 +252 @@
     }
 
-#if DEBUG_SYS_EXEC
-tm_end = hal_get_cycles();
-if( DEBUG_SYS_EXEC < tm_end )
-printk("\n[DBG] %s : thread %x in process %x exit / cost = %d / cycle %d\n",
-__FUNCTION__, this, pid, (uint32_t)(tm_end - tm_start), (uint32_t)tm_end );
-#endif
-
-    // In case of success, this calling thread deschedules, causing suicide,
-    // because a new process descriptor and its associated main thread 
-    // have been created by the process_make_exec() function, and the
-    // BLOCKED_GLOBAL & FLAG_REQ_DELETE bits have been set for the calling thread. 
-    sched_yield( "old process suicide in sys_exec()" );
+    assert( false , __FUNCTION__, "we should not execute this code" );
 
     return 0;