Changeset 523 for trunk


Ignore:
Timestamp:
Aug 30, 2018, 6:45:18 PM (3 years ago)
Author:
viala@…
Message:

[boot] Remove testing if a pointer is null.

It's a bad practice in a lib to hide undesired null pointers.
Using an assert is better.

Location:
trunk/boot/tsar_mips32
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/boot/tsar_mips32/boot_utils.c

    r521 r523  
    284284void boot_strcpy( char * dest, const char * src)
    285285{
    286     /* Checking if the arguments are correct. */
    287     if ((dest == NULL) || (src == NULL))
    288         return;
    289 
    290286    /* Copying the string. */
    291287    while ((*dest++ = *src++) != '\0');
     
    297293{
    298294    uint32_t res = 0;   /* Length of the string (in bytes).             */
    299 
    300     if (s != NULL)
    301     {
    302         while (*s++ != '\0')
    303             res++;
     295    while (*s++ != '\0') {
     296        res++;
    304297    }
    305298
    306299    return res;
    307 
    308300} // boot_strlen()
    309301
     
    311303int boot_strcmp( const char * s1, const char * s2 )
    312304{
    313     if ((s1 == NULL) || (s2 == NULL))
     305    if (s1 == s2)
    314306        return 0;
    315307
  • trunk/boot/tsar_mips32/boot_utils.h

    r521 r523  
    145145
    146146/****************************************************************************
    147  * This function copies the string pointed to by 'src' (the terminating 
    148  * null byte '\0' NOT included) to the buffer pointed to by 'dest'. 
    149  * @ src    : pointer to the string to be copied
    150  * @ dest   : pointer to the destination string.
     147 * This function copies the string pointed to by 'src' (the terminating
     148 * null byte '\0' NOT included) to the buffer pointed to by 'dest'.
     149 * @ src    : pointer to the string to be copied, should be not NULL.
     150 * @ dest   : pointer to the destination string, should be not NULL.
    151151 ****************************************************************************/
    152152void boot_strcpy( char* dest, const char * src );
     
    154154/****************************************************************************
    155155 * This function calculates the length of the string pointed to by 's',
    156  * excluding the terminating null byte '\0'. 
    157  * @ s  : pointer to the string whose length is to be computed.
    158  * @ returns the number of bytes in the string.
     156 * excluding the terminating null byte '\0'.
     157 * @ s  : pointer to the string whose length is to be computed,
     158 *        this pointer should be not NULL.
     159 * @ returns the number of bytes in the string.
    159160 ****************************************************************************/
    160161uint32_t boot_strlen( const char * s );
     
    162163/****************************************************************************
    163164 * This function compares the 2 strings pointed to by 's1' and 's2'.
    164  * @ s1 : pointer to the first string to be compared.
    165  * @ s2 : pointer to the second string to be compared.
    166  * @ returns 0 if these 2 strings match, 1 otherwise.
     165 * If pointers point to the same adress assumed to be equals.
     166 * @ s1 : pointer to the first string to be compared, should be not NULL.
     167 * @ s2 : pointer to the second string to be compared, should be not NULL.
     168 * @ returns 0 if these 2 strings match, 1 otherwise.
    167169 ****************************************************************************/
    168170int boot_strcmp( const char * s1, const char * s2 );
Note: See TracChangeset for help on using the changeset viewer.