Changeset 523 for trunk/boot/tsar_mips32/boot_utils.c

Timestamp:

Aug 30, 2018, 6:45:18 PM (6 years ago)

Author:

viala@…

Message:

[boot] Remove testing if a pointer is null.

It's a bad practice in a lib to hide undesired null pointers.
Using an assert is better.

File:

• trunk/boot/tsar_mips32/boot_utils.c (modified) (3 diffs)

trunk/boot/tsar_mips32/boot_utils.c

@@ -284 +284 @@
 void boot_strcpy( char * dest, const char * src)
 {
-    /* Checking if the arguments are correct. */
-    if ((dest == NULL) || (src == NULL))
-        return;
-
     /* Copying the string. */
     while ((*dest++ = *src++) != '\0');
@@ -297 +293 @@
 {
     uint32_t res = 0;   /* Length of the string (in bytes).             */
-
-    if (s != NULL)
-    {
-        while (*s++ != '\0')
-            res++;
+    while (*s++ != '\0') {
+        res++;
     }
 
     return res;
-
 } // boot_strlen()
 
@@ -311 +303 @@
 int boot_strcmp( const char * s1, const char * s2 )
 {
-    if ((s1 == NULL) || (s2 == NULL))
+    if (s1 == s2)
         return 0;