Changeset 527 for trunk/kernel/kern/chdev.c

Timestamp:

Aug 30, 2018, 10:26:27 PM (6 years ago)

Author:

viala@…

Message:

Rewrite if-then-else return function into switch case.

For safety reason and performance:

1) Safety: GCC complain with a warning if you forgot an enum variant.
2) code-gen just outperform naive if-then-else.

File:

• trunk/kernel/kern/chdev.c (modified) (1 diff)

trunk/kernel/kern/chdev.c

@@ -57 +57 @@
 char * chdev_func_str( uint32_t func_type ) 
 {
-        if     ( func_type == DEV_FUNC_RAM ) return "RAM";
-        else if( func_type == DEV_FUNC_ROM ) return "ROM";
-        else if( func_type == DEV_FUNC_FBF ) return "FBF";
-        else if( func_type == DEV_FUNC_IOB ) return "IOB";
-        else if( func_type == DEV_FUNC_IOC ) return "IOC";
-        else if( func_type == DEV_FUNC_MMC ) return "MMC";
-        else if( func_type == DEV_FUNC_DMA ) return "DMA";
-        else if( func_type == DEV_FUNC_NIC ) return "NIC";
-        else if( func_type == DEV_FUNC_TIM ) return "TIM";
-        else if( func_type == DEV_FUNC_TXT ) return "TXT";
-        else if( func_type == DEV_FUNC_ICU ) return "ICU";
-        else if( func_type == DEV_FUNC_PIC ) return "PIC";
-    else                                 return "undefined";
+  switch ( func_type ) {
+    case DEV_FUNC_RAM: return "RAM";
+    case DEV_FUNC_ROM: return "ROM";
+    case DEV_FUNC_FBF: return "FBF";
+    case DEV_FUNC_IOB: return "IOB";
+    case DEV_FUNC_IOC: return "IOC";
+    case DEV_FUNC_MMC: return "MMC";
+    case DEV_FUNC_DMA: return "DMA";
+    case DEV_FUNC_NIC: return "NIC";
+    case DEV_FUNC_TIM: return "TIM";
+    case DEV_FUNC_TXT: return "TXT";
+    case DEV_FUNC_ICU: return "ICU";
+    case DEV_FUNC_PIC: return "PIC";
+    default:           return "undefined";
+    }
 }