Changeset 538 for trunk


Ignore:
Timestamp:
Sep 21, 2018, 10:21:28 PM (3 years ago)
Author:
nicolas.van.phan@…
Message:

TTY MUX 3 : Comment multi_tty TX IRQ enabling

Enabling and disabling IRQs for TX by writing to the CONFIG register
has no effect on the behaviour of the vci_multi_tty regarding interrupts.
N.B. This is not the case for the vci_tty_tsar component.

Moreover, the hal_remote_atomic_cas() triggers a kernel panic for
unknown reasons so far.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/hal/tsar_mips32/drivers/soclib_mtty.c

    r537 r538  
    169169
    170170                // enable TX_IRQ
    171                 xptr_t config_xp = XPTR( tty_cxy , base + MTTY_CONFIG );
    172                 uint32_t old = hal_remote_lw( config_xp );
    173                 uint32_t new = old | MTTY_CONFIG_TX_ENABLE;
    174                 hal_remote_atomic_cas( config_xp , old , new );
     171                //      vci_multi_tty devices never raise TX IRQs
     172                //      so the following instructions are useless
     173                //      and moreover they kernel panic
     174                // xptr_t config_xp = XPTR( tty_cxy , base + MTTY_CONFIG );
     175                // uint32_t old = hal_remote_lw( config_xp );
     176                // uint32_t new = old | MTTY_CONFIG_TX_ENABLE;
     177                // hal_remote_atomic_cas( config_xp , old , new );
     178                // hal_remote_sw( XPTR( tty_cxy , base + MTTY_CONFIG ) , MTTY_CONFIG_TX_ENABLE );
    175179            }
    176180            else                                // block & deschedule if TX_FIFO full
     
    495499
    496500        // disable TX_IRQ
    497         xptr_t config_xp = XPTR( tty_cxy , base + MTTY_CONFIG );
    498         uint32_t old = hal_remote_lw( config_xp );
    499         uint32_t new = old & ~(MTTY_CONFIG_TX_ENABLE);
    500         hal_remote_atomic_cas( config_xp , old , new );
    501         //hal_remote_sw( XPTR( tty_cxy , base + MTTY_TX_IRQ_ENABLE ) , 0 );
     501        //      vci_multi_tty devices never raise TX IRQs
     502        //      so the following instructions are useless
     503        //      and moreover they kernel panic
     504        // xptr_t config_xp = XPTR( tty_cxy , base + MTTY_CONFIG );
     505        // uint32_t old = hal_remote_lw( config_xp );
     506        // uint32_t new = old & ~(MTTY_CONFIG_TX_ENABLE);
     507        // hal_remote_atomic_cas( config_xp , old , new );
     508        // hal_remote_sw( XPTR( tty_cxy , base + MTTY_CONFIG ) , 0 );
    502509
    503510        // unblock TXT_TX server thread
Note: See TracChangeset for help on using the changeset viewer.