Changeset 581 for trunk/kernel/kern/chdev.c

Timestamp:

Oct 10, 2018, 3:11:53 PM (6 years ago)

Author:

alain

Message:

1) Improve the busylock debug infrastructure.
2) introduce a non-distributed, but portable implementation for the pthread_barrier.

File:

• trunk/kernel/kern/chdev.c (modified) (3 diffs)

trunk/kernel/kern/chdev.c

@@ -154 +154 @@
     chdev_t * chdev_ptr = GET_PTR( chdev_xp );
 
-// check calling thread can yield
-assert( (this->busylocks == 0),
-"cannot yield : busylocks = %d\n", this->busylocks );
+    // check calling thread can yield
+    thread_assert_can_yield( this , __FUNCTION__ );
 
     // get local and extended pointers on server thread
@@ -197 +196 @@
     // build extended pointer on lock protecting chdev waiting queue
     lock_xp            = XPTR( chdev_cxy , &chdev_ptr->wait_lock );
+
+    // TODO the hal_disable_irq() / hal_restore_irq() 
+    // in the sequence below is probably useless, as it is 
+    // already done by the busylock_acquire() / busylock_release()
+    // => remove it [AG] october 2018
 
     // critical section for the following sequence: 
@@ -206 +210 @@
     // (6) release the lock protecting waiting queue
     // (7) deschedule
-    // ... in this order
 
     // enter critical section