Changeset 658 for trunk/hal/tsar_mips32/core/hal_uspace.c

Timestamp:

Oct 10, 2020, 3:48:50 PM (4 years ago)

Author:

alain

Message:

Improve the TSAR NIC driver.

File:

• trunk/hal/tsar_mips32/core/hal_uspace.c (modified) (9 diffs)

trunk/hal/tsar_mips32/core/hal_uspace.c

@@ -31 +31 @@
 
 ///////////////////////////////////////////////////////////////////////////////////////
-// This function moves <size> bytes from a source buffer in user virtual space,
-// defined by the <u_src_ptr> argument, to a destination kernel buffer, defined by the
-// <k_dst_xp> argument.
+// Implementation note
 // It works in a critical section, as it modifies two CP2 registers:
 // It activates briefly the DATA_MMU by writing into the CP2_MODE register to access the
@@ -41 +39 @@
 // If the buffers are not aligned, it moves all data byte per byte.
 ///////////////////////////////////////////////////////////////////////////////////////
-// @ k_dst_xp  : extended pointer on destination kernel buffer
-// @ u_src_ptr : pointer on source user buffer
-// @ size     : number of bytes to move
-///////////////////////////////////////////////////////////////////////////////////////
 void hal_copy_from_uspace( xptr_t     k_dst_xp,
                            void     * u_src_ptr,
@@ -55 +49 @@
     uint32_t cxy = (uint32_t)GET_CXY( k_dst_xp );
  
+assert( (CURRENT_THREAD->process->pid > 0), "must be called by an user thread" );
+
 #if DEBUG_HAL_USPACE
 thread_t * this  = CURRENT_THREAD;
@@ -133 +129 @@
 
 ///////////////////////////////////////////////////////////////////////////////////////
-// This function moves <size> bytes from a source kernel buffer, defined by the
-// <k_src_xp> argument, to a destination buffer in user virtual space, defined by 
-// the <u_dst_ptr> argument.
+// Implementation note
 // It works in a critical section, as it modifies two CP2 registers:
 // It activates briefly the DATA_MMU by writing into the CP2_MODE register to access the
@@ -143 +137 @@
 // If the buffers are not word aligned, it moves all data byte per byte.
 ///////////////////////////////////////////////////////////////////////////////////////
-// @ u_dst_ptr : pointer on destination user buffer
-// @ k_src_xp  : extended pointer on source kernel buffer
-// @ size      : number of bytes to move
-///////////////////////////////////////////////////////////////////////////////////////
 void hal_copy_to_uspace( void     * u_dst_ptr,
                          xptr_t     k_src_xp,
@@ -156 +146 @@
     uint32_t src = (uint32_t)GET_PTR( k_src_xp );
     uint32_t cxy = (uint32_t)GET_CXY( k_src_xp );
+
+assert( (CURRENT_THREAD->process->pid > 0), "must be called by an user thread" );
 
 #if DEBUG_HAL_USPACE
@@ -244 +236 @@
     uint32_t cxy = (uint32_t)GET_CXY( k_dst_xp );
 
+assert( (CURRENT_THREAD->process->pid > 0), "must be called by an user thread" );
+
     hal_disable_irq( &save_sr );
 
@@ -297 +291 @@
     uint32_t cxy = (uint32_t)GET_CXY( k_src_xp );
 
+assert( (CURRENT_THREAD->process->pid > 0), "must be called by an user thread" );
+
     hal_disable_irq( &save_sr );
 
@@ -346 +342 @@
     uint32_t count = 0;
     uint32_t str   = (uint32_t)u_str;
+
+assert( (CURRENT_THREAD->process->pid > 0), "must be called by an user thread" );
 
     hal_disable_irq( &save_sr );