Changeset 679 for trunk/hal/generic

Timestamp:

Nov 20, 2020, 12:30:31 AM (3 years ago)

Author:

alain

Message:

Mainly cosmetic.

Location:

trunk/hal/generic

Files:

• hal_context.h (modified) (3 diffs)
• hal_special.h (modified) (1 diff)
• hal_uspace.h (modified) (1 diff)
• hal_vmm.h (modified) (1 diff)

trunk/hal/generic/hal_context.h

@@ -2 +2 @@
  * hal_context.h - Generic Thread Context Access API definition.
  * 
- * Author  Alain Greiner    (2016,2017,2018,2019)
+ * Author  Alain Greiner    (2016,2017,2018,2019,2020)
  *
  * Copyright (c) UPMC Sorbonne Universites
@@ -50 +50 @@
 /****************************************************************************************
  * This function initializes the CPU context of the thread identified by the <thread>
- * argument. All slots required to start a new thread must be initialized.
+ * argument from the <thread> descriptor, depending on the thread type (user / kernel).
+ * All slots required to start a new thread must be initialized in the thread context.
+ * Moreover, for an user thread, the arguments to be passed to the entry function 
+ * depend on the <is_main> argument below:
+ * - a main thread, created by sys_exec(), requires two arguments, defined by the two
+ *   <argc> and <argv> arguments below.
+ *   define the arguments 
+ * - a pthread, created by sys_thread_create() requires only one argument, defined by
+ *   the "entry_args" field in the thread descriptor.
  ****************************************************************************************
  * @ thread  : pointer on the thread descriptor.
+ * @ is_main : main thread when non zero.
+ * @ argc    : actual number of arguments (for main).
+ * @ argv    : user space pointer on array of pointers on strings arguments (for main).
  ***************************************************************************************/
-void hal_cpu_context_init( struct thread_s * thread );
+void hal_cpu_context_init( struct thread_s * thread,
+                           bool_t            is_main,
+                           uint32_t          argc,
+                           intptr_t          argv );
 
 /****************************************************************************************
@@ -75 +89 @@
  ***************************************************************************************/
 void hal_cpu_context_fork( xptr_t    thread_xp );
-
-/****************************************************************************************
- * This function is used to implement the exec() system call. 
- * 1) It initialize the relevant slots of the the calling thread CPU context.
- * 2) It call the hal_do_cpu_restore() function to return to user mode and start
- *    execution of the new process.
- ****************************************************************************************
- * @ thread  : pointer on the thread descriptor.
- ***************************************************************************************/
-void hal_cpu_context_exec( struct thread_s * thread );
 
 /****************************************************************************************

trunk/hal/generic/hal_special.h

@@ -66 +66 @@
 
 /*****************************************************************************************
- * This function returns the current value of the hardware cycles counter.
+ * This low level function returns the current value of the hardware cycles counter.
  * This cycle counter is reset when the core is initialised (at each boot).
  ****************************************************************************************/

trunk/hal/generic/hal_uspace.h

@@ -95 +95 @@
 /*****************************************************************************************
  * This function returns the length of a string located in user space.
+ * This length does NOT include the terminating NUL character.
  *****************************************************************************************
- * @ string     : string in user space.
+ * @ string     : string pointer in user space.
  * @ return length of the string.
  ****************************************************************************************/

trunk/hal/generic/hal_vmm.h

@@ -2 +2 @@
  * hal_vmm.h - Kernel Virtual Memory Manager initialisation
  *
- * Authors  Alain Greiner (2016,2017,2018,2019)
+ * Authors  Alain Greiner (2016,2017,2018,2019,2020)
  *
  * Copyright (c) UPMC Sorbonne Universites