Changeset 635 for trunk/kernel/libk/remote_condvar.c

Timestamp:

Jun 26, 2019, 11:42:37 AM (5 years ago)

Author:

alain

Message:

This version is a major evolution: The physical memory allocators,
defined in the kmem.c, ppm.c, and kcm.c files have been modified
to support remote accesses. The RPCs that were previously user
to allocate physical memory in a remote cluster have been removed.
This has been done to cure a dead-lock in case of concurrent page-faults.

This version 2.2 has been tested on a (4 clusters / 2 cores per cluster)
TSAR architecture, for both the "sort" and the "fft" applications.

File:

• trunk/kernel/libk/remote_condvar.c (modified) (5 diffs)

trunk/kernel/libk/remote_condvar.c

@@ -2 +2 @@
  * remote_condvar.c - remote kernel condition variable implementation.
  *
- * Authors     Alain Greiner (2016,2017,2018)
+ * Authors     Alain Greiner (2016,2017,2018,2019)
  *
  * Copyright (c) UPMC Sorbonne Universites
@@ -86 +86 @@
 {
     remote_condvar_t * condvar_ptr;
-    xptr_t             condvar_xp;
+    kmem_req_t         req;   
 
     // get pointer on local process descriptor
@@ -98 +98 @@
     process_t * ref_ptr = (process_t *)GET_PTR( ref_xp );
 
-    // allocate memory for new condvar in reference cluster
-    if( ref_cxy == local_cxy )                              // local cluster is the reference 
-    {
-        kmem_req_t req;   
-        req.type    = KMEM_CONDVAR;
-        req.flags   = AF_ZERO;
-        condvar_ptr = kmem_alloc( &req );
-        condvar_xp  = XPTR( local_cxy , condvar_ptr );
-    }
-    else                                                   // reference cluster is remote
-    {
-        rpc_kcm_alloc_client( ref_cxy , KMEM_CONDVAR , &condvar_xp );
-        condvar_ptr = GET_PTR( condvar_xp );
-    }
-
-    if( condvar_xp == XPTR_NULL ) return 0xFFFFFFFF;
+    req.type    = KMEM_KCM;
+    req.order   = bits_log2( sizeof(remote_condvar_t) );
+    req.flags   = AF_ZERO | AF_KERNEL;
+    condvar_ptr = kmem_alloc( &req );
+
+    if( condvar_ptr == NULL )
+    {
+        printk("\n[ERROR] in %s : cannot create condvar\n", __FUNCTION__ );
+        return -1;
+    }
 
     // initialise condvar 
@@ -136 +130 @@
 void remote_condvar_destroy( xptr_t condvar_xp )
 {
+    kmem_req_t  req;
+
     // get pointer on local process descriptor
     process_t * process = CURRENT_THREAD->process;
@@ -166 +162 @@
 
     // release memory allocated for condvar descriptor
-    if( condvar_cxy == local_cxy )                            // reference is local
-    {
-        kmem_req_t  req;
-        req.type = KMEM_SEM;
-        req.ptr  = condvar_ptr;
-        kmem_free( &req );
-    }
-    else                                                  // reference is remote
-    {
-        rpc_kcm_free_client( condvar_cxy , condvar_ptr , KMEM_CONDVAR );
-    }
+    req.type = KMEM_KCM;
+    req.ptr  = condvar_ptr;
+    kmem_remote_free( ref_cxy , &req );
 
 }  // end remote_convar_destroy()